fix: macos prevent circular mapping#90
Merged
thisislvca merged 2 commits intoTomBadash:masterfrom Apr 21, 2026
Merged
Conversation
Collaborator
|
Thanks for the contribution on this one. I pushed a tiny follow-up fix for the unrelated Linux KEY_VOLUMEUP typo that was breaking CI, so the PR should be in a better spot now. |
Contributor
Author
|
@thisislvca thanks i dont know where that KEY_VOLUMEUP change comes from. i have the same in another PR |
Collaborator
|
No worries, I traced it back and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my config i had:
This was creating a circular mapping and i could not get mode_shift -> middle to work.
Now we mark cgevents as "injected" and thus it wont try to map it again